implement /ping #58
Draft
implement /ping #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
after we hit some issues with fpm and k8s and the respective probes i dicided it would be a saner approach to use /ping for actual "ping" checks to see if the service is alive at all.
previosly i used a simple connect via
cgi-fcgi -bind -connect 127.0.0.1:9000which triggered a nasty phpbug which is currently still open: php/php-src#15395after switching livenessProbe to just
php-fpm-healthcheckwe found another php bug php/php-src#13437in order to work around that, i propose to use the actual
/pingpage and make this the default, while not specifiying any test-arguments.Changes
what do you think about this aproach?